@sgiehl opened this Pull Request on January 14th 2019 Member

fixes #13701

@diosmosis commented on January 16th 2019 Member

This doesn't work for me on OS X, I presume because the 'cmd' key needs to be pressed in order to launch in a new tab ('ctrl' opens a popup menu).

@sgiehl commented on January 16th 2019 Member

@diosmosis could you check if metaKey instead of ctrlKey works on OS X? I don't have a Mac, so can't test it

@tsteur commented on January 16th 2019 Member

Can we change the HTML structure slightly to use an actual link for each site and the all websites plus ng-href or so which updates the link when things change? Then it would work properly on all OS etc

@sgiehl commented on January 16th 2019 Member

actually there are "real" links with hrefs for each site. But all clicks on those links are ignored because of piwik-ignore-click

@diosmosis commented on January 17th 2019 Member

@sgiehl w/ metaKey it works for me

@sgiehl commented on January 17th 2019 Member

@diosmosis added a check to use metaKey for OS X and ctrlKey for other systems

This Pull Request was closed on January 22nd 2019
Powered by GitHub Issue Mirror