Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open site in new tab/window if ctrl key is pressed #13960

Merged
merged 2 commits into from Jan 22, 2019
Merged

Open site in new tab/window if ctrl key is pressed #13960

merged 2 commits into from Jan 22, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 14, 2019

fixes #13701

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 14, 2019
@sgiehl sgiehl added this to the 3.9.0 milestone Jan 14, 2019
@diosmosis
Copy link
Member

This doesn't work for me on OS X, I presume because the 'cmd' key needs to be pressed in order to launch in a new tab ('ctrl' opens a popup menu).

@sgiehl
Copy link
Member Author

sgiehl commented Jan 16, 2019

@diosmosis could you check if metaKey instead of ctrlKey works on OS X? I don't have a Mac, so can't test it

@tsteur
Copy link
Member

tsteur commented Jan 16, 2019

Can we change the HTML structure slightly to use an actual link for each site and the all websites plus ng-href or so which updates the link when things change? Then it would work properly on all OS etc

@sgiehl
Copy link
Member Author

sgiehl commented Jan 16, 2019

actually there are "real" links with hrefs for each site. But all clicks on those links are ignored because of piwik-ignore-click

@diosmosis
Copy link
Member

@sgiehl w/ metaKey it works for me

@sgiehl
Copy link
Member Author

sgiehl commented Jan 17, 2019

@diosmosis added a check to use metaKey for OS X and ctrlKey for other systems

@diosmosis diosmosis merged commit 1d6fc94 into 3.x-dev Jan 22, 2019
@diosmosis diosmosis deleted the sitectrlclick branch January 22, 2019 00:52
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dzhuneyt Dzhuneyt Dzhuneyt approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.

Website selector: Ctrl+Click should open the website in a new tab
5 participants
@sgiehl @diosmosis @tsteur @Dzhuneyt @mattab