Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GeoIP Legacy Implementation and switch users to Db-ip #13957

Closed
sgiehl opened this issue Jan 14, 2019 · 7 comments · Fixed by #15521
Closed

Remove GeoIP Legacy Implementation and switch users to Db-ip #13957

sgiehl opened this issue Jan 14, 2019 · 7 comments · Fixed by #15521
Assignees
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Jan 14, 2019

Maxmind has completely discontinued GeoIP Legacy Lite support. No databases in that format are available for free download anymore. Commercial databases might still be up (don't have access, so can't check if that's the case)

See https://support.maxmind.com/geolite-legacy-discontinuation-notice/

Therefor we completely should remove the GeoIP Legacy support in one of the upcoming version or a least in 4.0.

The GeoIP Legacy Autoupdater should already be removed (or automatically be disabled if a GeoLite DB is configured) in one of the next releases as it can't work anymore.

@mattab
Copy link
Member

mattab commented Jan 14, 2019

Is the core:archive process failing for geoip1 users now that the DB downloads are discontinued? if so please assign to the next milestone.

@sgiehl
Copy link
Member Author

sgiehl commented Jan 14, 2019

if the task runs it fails:

ERROR [2019-01-14 10:54:40] 42709  /var/www/piwik_test/plugins/UserCountry/GeoIPAutoUpdater.php(167): GeoIPAutoUpdater: failed to unzip '/var/www/piwik_test/misc/GeoIPCity.dat.dat.gz' after downloading 'http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz': The downloaded file is not a valid GeoIP database. Please re-check the URL or download the file manually.


Error: error or warning logs detected, exit 1

@mattab
Copy link
Member

mattab commented Dec 24, 2019

we'll probably stop using Maxmind soon, so closing this issue now, see #15308 - feel free to re-open if there is actually something we should do

@mattab mattab closed this as completed Dec 24, 2019
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Dec 24, 2019
@sgiehl
Copy link
Member Author

sgiehl commented Dec 24, 2019

We still need to remove the old GeoIP implementation and force users to switch to GeoIP2. It doesn't matter if the new GeoIP2 database will be from Maxmind or DB-IP
Note: The paid GeoIP (Legacy) databases from Maxmind are still available, but might be discontinued soon.

@sgiehl sgiehl reopened this Dec 24, 2019
@sgiehl sgiehl removed the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Dec 24, 2019
@mattab
Copy link
Member

mattab commented Jan 21, 2020

Assigning to Matomo 4.0.0 as it seems a good time for it, but feel free to move it out if not possible

@mattab mattab added this to the 4.0.0 milestone Jan 21, 2020
@mattab mattab changed the title Remove GeoIP Legacy Implementation and force users to switch to GeoIP 2 Remove GeoIP Legacy Implementation and switch users to Db-ip Jan 31, 2020
@sgiehl sgiehl self-assigned this Feb 6, 2020
@tsteur
Copy link
Member

tsteur commented Feb 6, 2020

BTW be good if for users things happen automatically and they are switched over.

Is there any issue if they were using Apache or other things to authenticate? As part of Matomo 4 we could otherwise also simply have a warning show up to super users they should be upgrading to GeoIP2 and then remove it as part of Matomo 5?

MaxMind DBs still work after signing up right?
No preference though. Don't know if old DBs are still available. I suppose we can also migrate them now but then we should have a big warning as part of Matomo 3 mentioning they should upgrade to Geoip2. Mostly concerened about users that do geolocation server based and we maybe can't migrate them automatically. Might not be a big issue though.

Nonetheless a warning as part of Matomo 3 be great.

@sgiehl
Copy link
Member Author

sgiehl commented Feb 6, 2020

Imho we can't simply switch them over. Downloading the new database and setting up the provider without any action doesn't sound right for me. I will add a warning in the admin for superusers that they need to configure a new geolocation provider, if GeoIP Legacy was used before...

People still using GeoIP Legacy will also have the "issue", that old data was stored with the FIPS region codes, whereas GeoIP2 will use ISO codes. So they need to run the console command to update them or the old data might not be displayed correctly everywhere...

And this only affects the old Geo IP implementation that was using Maxminds *.dat files. The Lite version is already no longer available. The paid databases are still available, but deprecated for a long while already. The new Maxmind databases *.mmdb will still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants