Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto generated Password Reset email is missing white space in the footer #13953

Closed
mattab opened this issue Jan 14, 2019 · 0 comments · Fixed by #16687
Closed

Auto generated Password Reset email is missing white space in the footer #13953

mattab opened this issue Jan 14, 2019 · 0 comments · Fixed by #16687
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.5.0

Comments

@mattab
Copy link
Member

mattab commented Jan 14, 2019

In the "Password reset" email, the text appears too close to the bottom border. see: untitled

Let's add at least a line break and also check that other generated emails won't be affected by this issue.
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Jan 14, 2019
@mattab mattab added this to the 4.3.0 milestone Jan 21, 2020
@mattab mattab added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Jan 21, 2020
@nina-py nina-py mentioned this issue Nov 9, 2020
Merged
9 tasks
tsteur pushed a commit that referenced this issue Nov 10, 2020
@nina-py
Added whitespace to the bottom of email template (#16687)
9676053 
The issue was that the div element that wrapped the contents of the email
had both top and bottom margins set to zero. There is spacing between
the email text and the (dark blue) header thanks to the 25px bottom margin
on the header. Added a matching 25px bottom margin on the wrapper div.

Fixes #13953.
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

Added whitespace to the bottom of email template
1 participant
@mattab