Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a fatal error is issued within a popover, show message instead of "forever loading" #13951

Closed
mattab opened this issue Jan 14, 2019 · 0 comments · Fixed by #14424
Closed

When a fatal error is issued within a popover, show message instead of "forever loading" #13951

mattab opened this issue Jan 14, 2019 · 0 comments · Fixed by #14424
Assignees
@katebutler
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
3.12.0

Comments

@mattab
Copy link
Member

mattab commented Jan 14, 2019

It would be valuable for users that when PHP or Matomo fails and return fatal error, that we somehow manage to show this error message in the popovers as well...

To reproduce:

  • Open a report with row evolution feature
  • Introduce a fatal error in the code (or lower memory setting to cause PHP to fail)
  • Click on Row Evolution icon
  • Got: the popover for Row Evolution shows "Loading Row Evolution..." forever, and likely a JavaScript error in the browser console such as TypeError: self.datatable is null
  • Expected instead: The popover for Row Evolution should show the error message in red like this and ask to contact support/ask in forums (we have links to Forums/Support in the fatal error notifications already in Matomo so be great to reuse those)
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Jan 14, 2019
@mattab mattab added this to the 3.10.0 milestone Jan 14, 2019
@katebutler katebutler self-assigned this May 6, 2019
@katebutler katebutler mentioned this issue May 7, 2019
Merged
@mattab mattab modified the milestones: 3.11.0, 3.12.0 Jul 23, 2019
@mattab mattab changed the title When PHP or Matomo issues a fatal error (for any reason), and the page is in a popover, show error message to user instead of "forever loading" When a fatal error is issued within a popover, show message instead of "forever loading" Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katebutler katebutler

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging a pull request may close this issue.

Display error message after encountering ajax error in popover matomo-org/matomo
2 participants
@mattab @katebutler