Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra plugins to load to test env manipulators fake plugin list. #13949

Merged
merged 1 commit into from Jan 22, 2019
Merged

Add extra plugins to load to test env manipulators fake plugin list. #13949

merged 1 commit into from Jan 22, 2019

Conversation

diosmosis
Copy link
Member

This way plugins are added to the list when the DI container is created, so DI config for plugins will be loaded during tests when Fixture::$extraPluginsToLoad is set.

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 11, 2019
@diosmosis diosmosis added this to the 3.9.0 milestone Jan 11, 2019
@diosmosis
Copy link
Member Author

@tsteur merging, just fyi

@diosmosis diosmosis merged commit dc740d2 into 3.x-dev Jan 22, 2019
@diosmosis diosmosis deleted the tests-extra-plugins branch January 22, 2019 01:41
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab