Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readable segment values for browser, os and country segments #13929

Merged
merged 6 commits into from Apr 10, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 3, 2019

Current segments for browser, os or country are only usable using the short code (e.g. FF, IE, WIN, IOS, de, fr, ...).

refs #5309
fixes #6772
refs #14053

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jan 3, 2019
@@ -17,12 +18,23 @@ class BrowserName extends Base
{
protected $columnName = 'config_browser_name';
protected $columnType = 'VARCHAR(10) NULL';
protected $segmentName = 'browserCode';
protected $segmentName = 'browserName';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR is still WIP but be good to not break API and keep the existing segment browserCode etc. We could also make the segment accept browser names on top besides browserCode or add another segment browserName.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. There will be two segments each browserName and browserCode and same for os.

@tsteur tsteur added this to the 3.10.0 milestone Jan 6, 2019
@sgiehl sgiehl added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jan 28, 2019
@sgiehl
Copy link
Member Author

sgiehl commented Jan 28, 2019

Expected test files may need an update before merging

@sgiehl sgiehl changed the title Readable segment values for browser and os segments Readable segment values for browser, os and country segments Feb 5, 2019
@sgiehl
Copy link
Member Author

sgiehl commented Feb 5, 2019

I've updated the branch and added an additional segment for the english country name

@sgiehl
Copy link
Member Author

sgiehl commented Apr 7, 2019

@diosmosis browser and os names should now be compared case insensitive

@diosmosis
Copy link
Member

I'm seeing this change in the tests:

-    <segment>countryCode==gb</segment>
+    <segment>countryName==gb</segment>

Is that correct? Reporting APIs may need to be changed possibly...

@sgiehl
Copy link
Member Author

sgiehl commented Apr 9, 2019

@diosmosis no, I've updated the code, so that doesn't change. Tests should also be updated now.

@diosmosis diosmosis merged commit beff637 into 3.x-dev Apr 10, 2019
@diosmosis diosmosis deleted the segmentvalues branch April 10, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeviceDetection segment editor auto suggested values should show full strings
4 participants