Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to unsanitize search keyword #13928

Merged
merged 2 commits into from Jan 22, 2019
Merged

Ensure to unsanitize search keyword #13928

merged 2 commits into from Jan 22, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 3, 2019

keyword (like everything else) is stored sanitized in database, which causes quotes to be displayed encoded in Matomo in visits/realtime log.

fixes #4018

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 3, 2019
@tsteur tsteur added this to the 3.9.0 milestone Jan 3, 2019
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good if tests pass, tested for xss as well.

@diosmosis diosmosis merged commit 8d39c9c into 3.x-dev Jan 22, 2019
@diosmosis diosmosis deleted the searchkeyword branch January 22, 2019 05:04
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visitors in Real-time plugin: entity codes showed
4 participants