Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current segment also in Segmented Visitorlog #13921

Merged
merged 1 commit into from Jan 22, 2019
Merged

Use current segment also in Segmented Visitorlog #13921

merged 1 commit into from Jan 22, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 30, 2018

this simple change should be enough so append the current (global) segment to the segment of the segmented visitor log.

fixes #13344

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 30, 2018
@sgiehl sgiehl added this to the 3.9.0 milestone Dec 30, 2018
@tsteur
Copy link
Member

tsteur commented Dec 30, 2018

Just tested it and works for me. By the looks Funnels and Form Analytics seems to use .show() and already set the segment by the looks so should be all fine 👍 Not sure if used anywhere else.

@diosmosis diosmosis merged commit d24e794 into 3.x-dev Jan 22, 2019
@diosmosis diosmosis deleted the segmentedlogsegment branch January 22, 2019 05:06
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.

Segmented visitor log does not inherit existing segment
4 participants
@sgiehl @tsteur @diosmosis @mattab