@sgiehl opened this Pull Request on December 27th 2018 Member

first approach to improve the action listing layout:

image

I've only done some CSS changes by now. But we should also replace all icons with new ones, so they have the same size and look.

fixes #13332
refs #12770

@tsteur commented on December 27th 2018 Member

Be awesome to use nice icons, even for page views. I would probably also change some icons eg the "event" icon is not really clear etc.

BTW: I'm thinking a grey line, and having a minimum height for each line separator might look better see https://user-images.githubusercontent.com/273120/44558721-d6c6fc80-a799-11e8-82e3-fc33f1890568.png

@sgiehl commented on December 28th 2018 Member

I've tweaked the UI a bit and added some new icons from the materialize icon set. Now looks like this:
image

Did not spent too much time to search for proper icons by now, but currently I've added those:

image

@sgiehl commented on January 3rd 2019 Member

Also updated the folder icon used in realtime widget, and reused it for normal actions in visitor log as well:

image

@diosmosis commented on January 14th 2019 Member

Code looks good, tested locally and the icons look a bit dark. Think it might look better if the icons are a bit lighter, to differentiate with text on the right and the "N Actions" label?

@diosmosis commented on January 31st 2019 Member

@sgiehl can you take a look at my last comment?

@sgiehl commented on January 31st 2019 Member

@diosmosis I've lightened the icons a bit:
image

Feel free to adjust the colors a bit more. But actually all icons are currently only a suggestions. Maybe someone is keen on looking for some better ones?

@diosmosis commented on January 31st 2019 Member

Maybe someone is keen on looking for some better ones?

They honestly look quite good to me. Any thoughts @tsteur / @mattab (when you're back)?

I'd like to merge this soon, we can always change the icons later.

@tsteur commented on January 31st 2019 Member

image
image

To me it looks a bit dark, and sometimes the icons are not aligned with the text. It be awesome if the first line was always centred vertically with the icon.

Also I think the vertical line and the icons shouldn't have the same color similar to https://user-images.githubusercontent.com/273120/44558721-d6c6fc80-a799-11e8-82e3-fc33f1890568.png

I feel like we may also need to tweak the spacing a bit but this can be done afterwards.
image

Eg it may be worth it to try always having things over two lines when possible so it looks bit less messy. But of course that's not always possible etc. We could ask a designer for some tweaks if needed.

@diosmosis commented on February 6th 2019 Member

@sgiehl will you be able to address @tsteur's comment?

@sgiehl commented on February 7th 2019 Member

I've updated the branch and adjusted the colors and alignment a bit more.

Note: Icons from our premium plugins (media / form) need to be adjusted to have the same color/size afterwards...

@diosmosis commented on February 8th 2019 Member

Code looks good, though I think the icons could be even lighter, eg:

image

vs:

image

What do you thin @sgiehl, @tsteur? Will probably merge this PR as is in order to avoid going back forth forever, but can make a change in another PR if you guys agree.

@tsteur commented on February 10th 2019 Member

Sound good @diosmosis and yes would make them even lighter.

@diosmosis commented on February 10th 2019 Member

Noticed this gets rid of the goal conversion counter in a visit, eg:

image

(see the flag next to the cart)

Is this expected?

@sgiehl commented on February 11th 2019 Member

I removed that because it looked quite ugly with the new icons and the border. But without the border the number looked a bit weird between the icons... Not sure if the goal count is that relevant (it's still shown on hover). Actually I don't have a good idea how to design that in a way it looks good

@diosmosis commented on February 11th 2019 Member

I think it's ok to show it on hover... what do you think @mattab / @tsteur ?

@tsteur commented on February 11th 2019 Member

Personally, I'm thinking it would be quite useful to still have the info directly visible how many goals were converted maybe in front of the icon. but it's also not too crazy important and on hover could be fine. not sure how often it would be really needed.

@diosmosis commented on February 11th 2019 Member

What about a number in a small green circle at the bottom right of the icon? Like the number of notifications in some apps:
image

@tsteur commented on February 12th 2019 Member

could work if the icon and number is identifiable when it's shown so small 👍

@sgiehl commented on February 12th 2019 Member

Implemented this. Now looks like this
image
Feel free to adjust the color

@tsteur commented on February 12th 2019 Member

Looks good 👍

@diosmosis commented on February 12th 2019 Member

The visitor log looks much better w/ this PR!

This Pull Request was closed on February 12th 2019
Powered by GitHub Issue Mirror