@Findus23 opened this Pull Request on December 27th 2018 Member

After a quite long time the tests are now back to green as I added icons to the new device-detector brands and fixed imagemagick (it turns out -floodfill does not floodfill as one would expect if the selected pixel doesn't already have the to-be-filled color, but the obscure -draw "color 0,0 floodfill" does)

@sgiehl What was the reason for https://github.com/matomo-org/matomo/commit/a8afbc8b5b14fbaa20062d82440dcb2b77b173b0?
(It may be useful to wait with fixing the UI-tests until they succeed on 3.x-dev as thanks to imagemagick-patch-updates some single pixels change and break the ui-tests (example))

@sgiehl commented on December 27th 2018 Member

@Findus23 actually I updated it accidentally in another commit before. But I had to revert it due to the failing tests caused by a submodule of the icons repo: https://travis-ci.org/matomo-org/matomo/jobs/469101972

@Findus23 commented on December 27th 2018 Member

@sgiehl I noticed that one of the submodules changed the git history and the commit wasn't available anymore. I have since fixed it, so this should be solved.

This Pull Request was closed on December 31st 2018
Powered by GitHub Issue Mirror