update icons submodule #13914
Merged
update icons submodule #13914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
Task
|
@Findus23 actually I updated it accidentally in another commit before. But I had to revert it due to the failing tests caused by a submodule of the icons repo: https://travis-ci.org/matomo-org/matomo/jobs/469101972 |
|
@sgiehl I noticed that one of the submodules changed the git history and the commit wasn't available anymore. I have since fixed it, so this should be solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a quite long time the tests are now back to green as I added icons to the new device-detector brands and fixed imagemagick (it turns out
-floodfilldoes not floodfill as one would expect if the selected pixel doesn't already have the to-be-filled color, but the obscure-draw "color 0,0 floodfill"does)@sgiehl What was the reason for a8afbc8?
(It may be useful to wait with fixing the UI-tests until they succeed on 3.x-dev as thanks to imagemagick-patch-updates some single pixels change and break the ui-tests (example))