@diosmosis opened this Pull Request on December 26th 2018 Member

Fixes #11384

Bugs fixed:

  • When segment selector redirects to new segment, must make sure value is triple encoded to match 3 urldecodes done server side.
  • Quotes and ampersands must be replaced globally throughout whole segment string, not just for first occurrence.
@tsteur commented on December 26th 2018 Member

When segment selector redirects to new segment, must make sure value is triple encoded to match 3 urldecodes done server side.

@diosmosis must have missed that. Can you point me to the change or where this is done? 3 urldecodes are quite a few :) were we also not breaking anything when we did that?

@diosmosis commented on December 26th 2018 Member

@tsteur I wrote about it in this PR description: https://github.com/matomo-org/matomo/pull/13481

@tsteur commented on December 26th 2018 Member

i see guess that makes sense. not sure re possible side effects.

@diosmosis commented on December 26th 2018 Member

These changes should only affect the segment editor (ie, the segment definition that gets saved & what we redirect to). I suppose it might not recognize definitions for old segments that were created improperly... not too sure. Will test a bit more.

@mattab commented on December 31st 2018 Member

@diosmosis did you maybe have a chance to do more tests?

@diosmosis commented on January 3rd 2019 Member

Did some more testing, seems to work, couldn't find any issues.

Powered by GitHub Issue Mirror