Make sure all Matomo emails use correct branding. #13908
Conversation
diosmosis
added
not-in-changelog
|
Semi-related: |
|
FYI Updated email logo. |
| && \Piwik\Plugin\Manager::getInstance()->isPluginActivated('WhiteLabel') | ||
| && \Piwik\Plugin\Manager::getInstance()->isPluginInFilesystem('WhiteLabel'); | ||
|
|
||
| $view->idSite = Common::getRequestVar('idSite', false); |
There was a problem hiding this comment.
Not sure about those 3 lines. Are they needed @diosmosis ? For what? Cause the current set idSite in the request might not be related to any sent email. Same for period or date. Sometimes there eg hooks that listen to something like a plugin update, and then send an email about something totally else.
There was a problem hiding this comment.
These three params are used in the dashboard link in the email header. Some emails had it, some didn't. Thought I'd add it to all if the params were available.
There was a problem hiding this comment.
Wouldn't we want to link the the default report?
There was a problem hiding this comment.
This is how the code worked before, but I can change it to link to what's configured in settings.
There was a problem hiding this comment.
Nvm, it already does this (by linking to CoreHome.index).
There was a problem hiding this comment.
Wouldn't it need to link to CoreHome.redirectToCoreHomeIndex (requires no site, period, date, ... AFAIK)? I guess the only time we wouldn't want this is when a report is sent for a specific site. In all cases might make sense to load the default report and default time to load.
There was a problem hiding this comment.
Yes, would need to link to redirectToCoreHomeIndex or I guess to omit the action. I can make this change, except when a specific site is set.
|
Not sure if it is due to this PR but the sender is "Matomo Reports"... even when eg getting update notification |
|
Likely unrelated to this... noticed the bullet points are smaller in the scheduled reports than the rest of the font... didn't look in the code if it was before already like this
|
|
I suppose Custom alerts will need to be updated as well? Possibly also the mail send in QueuedTracking https://github.com/matomo-org/plugin-QueuedTracking/blob/3.3.1/Tasks.php#L73-L84 but not too important |
Looks like that's the default report name if |
|
@tsteur re the bullet points, does this look better?
|
|
Forgot to create the PR for CustomAlerts, can find it here: matomo-org/plugin-CustomAlerts#54 |
…ke dashboard link got to default erport in emails.
|
Created a queued tracking PR as well: matomo-org/plugin-QueuedTracking#93 |
|
@diosmosis it should be fine as long as it is using the same font size 👍 |
|
It is now, think it was using the default chrome font size before. |
|
@diosmosis had a look at the other PRs and looks all good. I reckon can be merged as soon as tests succeed 👍 |
Fixes #13251