@diosmosis opened this Pull Request on December 26th 2018 Member

Fixes #13251

@Findus23 commented on January 2nd 2019 Member

Semi-related:
plugins/Morpheus/images/logo-email.png still shows the old Matomo logo

@tsteur commented on January 2nd 2019 Member

FYI Updated email logo.

@tsteur commented on January 2nd 2019 Member

Not sure if it is due to this PR but the sender is "Matomo Reports"... even when eg getting update notification
image

@tsteur commented on January 2nd 2019 Member

Likely unrelated to this... noticed the bullet points are smaller in the scheduled reports than the rest of the font... didn't look in the code if it was before already like this

image

@tsteur commented on January 2nd 2019 Member

I suppose Custom alerts will need to be updated as well? Possibly also the mail send in QueuedTracking https://github.com/matomo-org/plugin-QueuedTracking/blob/3.3.1/Tasks.php#L73-L84 but not too important

@diosmosis commented on January 2nd 2019 Member

Not sure if it is due to this PR but the sender is "Matomo Reports"... even when eg getting update notification

Looks like that's the default report name if [General] noreply_email_name isn't set. Wonder if it should just be from Matomo or something?

@diosmosis commented on January 3rd 2019 Member

@tsteur re the bullet points, does this look better?

image

@diosmosis commented on January 3rd 2019 Member

Forgot to create the PR for CustomAlerts, can find it here: https://github.com/matomo-org/plugin-CustomAlerts/pull/54

@diosmosis commented on January 3rd 2019 Member

Created a queued tracking PR as well: https://github.com/matomo-org/plugin-QueuedTracking/pull/93

@tsteur commented on January 3rd 2019 Member

@diosmosis it should be fine as long as it is using the same font size 👍

@diosmosis commented on January 3rd 2019 Member

It is now, think it was using the default chrome font size before.

@tsteur commented on January 3rd 2019 Member

@diosmosis had a look at the other PRs and looks all good. I reckon can be merged as soon as tests succeed 👍

This Pull Request was closed on January 4th 2019
Powered by GitHub Issue Mirror