New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve RSS fetching #13904
improve RSS fetching #13904
Conversation
@Findus23 any chance we could not show the last part of each article saying "... appeared first on ..."? |
@tsteur That was the reason why I initially looked into the rss fetching. |
#widgetRssWidgetrssPiwik .read-more-container+p {
display: none;
} something like this should do 👍 |
@tsteur It is unfortunately not in a special class, but removing it via PHP seems easy. There should also be a working cache now. |
@Findus23 " It is unfortunately not in a special class" do you mean that the sentence doesn't have a class? Cause the selector should still work. At least when I tested it ... or is the problem in case it changes in the future? |
@tsteur <p>There’s no doubt about it, the free version of Google Analytics offers great value when it comes to making
data-driven decisions for your business. But as your business starts to grow, so does the need for a more powerful
web ... </p>
<p class="read-more-container">
<a title="Why Matomo is a serious alternative to Google Analytics 360"
class="read-more button"
href="https://matomo.org/blog/2018/12/why-matomo-is-a-serious-alternative-to-google-analytics-360/#more-30938">
Read More
<span class="screen-reader-text">
Why Matomo is a serious alternative to Google Analytics 360
</span>
</a>
</p>
<p>The post
<a rel="nofollow"
href="https://matomo.org/blog/2018/12/why-matomo-is-a-serious-alternative-to-google-analytics-360/">
Why Matomo is a serious alternative to Google Analytics 360</a> appeared first on
<a rel="nofollow" href="https://matomo.org">Analytics
Platform - Matomo</a>.
</p> So by hiding |
Did you try this? #widgetRssWidgetrssPiwik .read-more-container+p {
display: none;
} it should select it or am I not understanding it? |
@tsteur That should also work. Do you think this is less prone to break in the future? |
Not 100% sure which is better. Do we know the feed is always retrieved in English? If the wording changes it might break vs CSS will still work. Both have advantages and disadvantages really. |
@tsteur Of course there is the even better solution: Removing the extra text that seems to be added by |
changed it @Findus23 |
@tsteur Thanks I removed the PHP code and it seems to work fine. |
Not sure about that, probably not. I reckon we would need to put this behind our CDN but https://static.matomo.org/feed/ currently redirects to matomo.org and would need to figure out how to disable this redirect in wordpress. |
Noticed links in rss content didn't have |
Fixes #5214
While we are on the topic of improving old widgets:
.screen-reader-text
summary directly afterRead More
, which needs to be hiddenSemi-related: https://matomo.org/faq/how-to/faq_99/ should also be removed, archived or updated.
BTW: Feedburner adds tracking-pixels to the feed, but only to the content, so Matomo isn't affected