Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix donate widget #13901

Merged
merged 2 commits into from Dec 31, 2018
Merged

fix donate widget #13901

merged 2 commits into from Dec 31, 2018

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Dec 21, 2018

  • fixes the recurring donation widget (on0 has to be Piwik Supporter)
  • doesn't allow to modify the redirected URL
  • removes bb2_screener_ parameter. I am pretty sure it doesn't do anything.
  • fix image breaking into the next line when selecting $120/yr.

@Findus23 Findus23 added the Needs Review PRs that need a code review label Dec 21, 2018
if (empty($parameters["onetime"]) || $parameters["onetime"] != "true") {
$paypalParameters["hosted_button_id"] = "DVKLY73RS7JTE";
$paypalParameters["currency_code"] = "USD";
$paypalParameters["on0"] = "Piwik Supporter";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to change something in paypal setting to make it work for Matomo Supporter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. Using Matomo Supporter just shows a Paypal error. I guess this is the name of the paypal "product".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattab could you add this product to PayPal or configure it somehow?

@mattab mattab self-assigned this Dec 31, 2018
@mattab mattab added this to the 3.9.0 milestone Dec 31, 2018
@mattab mattab merged commit c856333 into 3.x-dev Dec 31, 2018
@mattab mattab deleted the fix-paypal-widget branch December 31, 2018 03:57
@Findus23
Copy link
Member Author

As this has been merged, I guess we should move it from 3.9.0 to 3.8.0

@mattab mattab modified the milestones: 3.9.0, 3.8.0 Jan 14, 2019
@Findus23 Findus23 restored the fix-paypal-widget branch October 4, 2019 09:48
@sgiehl sgiehl deleted the fix-paypal-widget branch February 10, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants