Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklist IP addresses are labeled 'Never block these IPs from logging in' #13899

Closed
gizmocuz opened this issue Dec 21, 2018 · 1 comment · Fixed by #13903
Closed

Blacklist IP addresses are labeled 'Never block these IPs from logging in' #13899

gizmocuz opened this issue Dec 21, 2018 · 1 comment · Fixed by #13903
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.8.0

Comments

@gizmocuz
Copy link

In the settings page, the label to actually 'Blacklist' IP's is labeled 'Never block these IPs from logging in'
This should be something like 'Block these IPs from logging in'

This is causing admins to be blocked!
(had to configure the plugin settings table (blacklistedBruteForceIps))
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 21, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 21, 2018
tsteur added a commit that referenced this issue Dec 21, 2018
@tsteur
Fix wording in brute force system setting
dc9b544 
fix #13899
@tsteur tsteur mentioned this issue Dec 21, 2018
Merged
@tsteur
Copy link
Member

tsteur commented Dec 21, 2018

thanks for reporting it 👍

diosmosis pushed a commit that referenced this issue Dec 22, 2018
@tsteur @diosmosis
Fix wording in brute force system setting (#13903)
2c3a899 
fix #13899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Fix wording in brute force system setting matomo-org/matomo
2 participants
@tsteur @gizmocuz