@tsteur opened this Pull Request on December 21st 2018 Member

fix #13800

I'm thinking this should improve the performance of the delete queries:

  • Before it would run all the delete queries mentioned in #13800 every week even if no site was deleted
  • Before it would potentially do a full table scan but now the where idsite in(...) should only lock rows belonging to that site. New tracking requests for those rows / idsite shouldn't come in cause the site no longer exists (would be discarded by tracker) so it shouldn't be a problem.

Initially I also implemented a check for each table that had idsite column to check if tracking requests for that site exists and only delete if the log table has tracking requests for that site, but it shouldn't be needed.

This Pull Request was closed on December 22nd 2018
Powered by GitHub Issue Mirror