Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code library adds several new files to vendor dir that is breaking build #13889

Merged
merged 5 commits into from Dec 21, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 20, 2018

Worked for me. Likely only need to adjust ui test.

fix #13794

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 20, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 20, 2018
@tsteur
Copy link
Member Author

tsteur commented Dec 20, 2018

Fixed UI tests

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely. Tested on Chrome and IE11

@tsteur tsteur merged commit 35c76b4 into 3.x-dev Dec 21, 2018
@tsteur tsteur deleted the 13794 branch December 21, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR code library adds several new files to vendor dir that is breaking build
2 participants