Make sure to group the label in Referrer Websites report #13884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just debugged and can confirm behaviour described in #13882 The label includes a URL like `http://demo.matomo.org/foo/bar` and the label is then removed in the `ColumnCallbackReplace` filter meaning there could be several entries with the same label and a group by is needed.
tsteur
added
not-in-changelog
tsteur
added
Needs Review
|
User confirmed it works, might cause the report to load a little less slow since the filters needed to be executed directly and the GroupBy is not the fastest either. |
diosmosis
reviewed
Apr 3, 2019
|
There's an interesting test failure w/ the Others row. Also probably good to have this bug covered by a system test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just debugged and can confirm behaviour described in #13882
The label includes a URL like
http://demo.matomo.org/foo/barand the label is then removed in theColumnCallbackReplacefilter meaning there could be several entries with the same label and a group by is needed.