New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions_SubmenuPageTitles : two lines in report for same page title #13880
Comments
Can you post a screenshot maybe to clarify what you mean by "two lines for same page". Does the title maybe include a |
Yes, I think it's related to 3.8.0-b4 as I upgrade to it on 12 december. I have removed the page title, but it is the same. It's a one page site.
There is some For another website and same Matomo, some "double line" title have no special characters at all. For this other website, it's only for page that have been visited beyond the twelve of december and today. |
Could you paste the exact titles? Feel free to change the letters... Are there maybe any extra spaces in the middle or something? |
One link to the one page website ( The one from the screenshot) : removed. |
OK thanks. Maybe you could email us an image of the two titles to hello at matomo.org just to get a better understanding. Feel free to remove the link again. |
The mail has been sent. I just had some datas to one Android app tracked with matomo-android-sdk , stats are public, the same thing happened. |
Cheers for sending the mail 👍 I've tried to reproduce by tracking it first with Matomo 3.7.0 and then with Matomo 3.8.0-b5 but didn't run into the problem. Thanks though for sending the link and I can now see the issue. There is one entry with a leading space, and another without... Makes me realise this might only happen when period != day. I remember when a delimiter is set, it may add a space here https://github.com/matomo-org/matomo/blob/3.8.0-b5/plugins/Actions/ArchivingHelper.php#L468-L477 but don't quite understand the problem. and thought that https://github.com/matomo-org/matomo/compare/3.x-dev...13880?quick_pull=1 might fix the issue but not sure if this would have any side effects. @diosmosis @mattab @sgiehl do you maybe know why exactly the whitespace is prepended? |
Note: putting this into 3.8.0 to look at it as it may or may not be considered a regression. It was expected there would be a difference when the title contains |
No, I haven't set any custom title delimiter. This happened too with page title without any special character. For example a two words title : Foo Bar and the same with one word title like
|
Cheers 👍 I can see this might be an issue for all pages... so maybe a fix like this could be more appropriate where we still keep prepending the whitespace https://github.com/matomo-org/matomo/compare/3.x-dev...13841_2?quick_pull=1 ... it's a bit funny but might be the safest fix. Still not understanding why we prepend titles with a whitespace. |
@tsteur Is the whitespace important or can it be removed? Would using a GroupBy filter w/ |
That's what I thought and did in https://github.com/matomo-org/matomo/compare/3.x-dev...13880?quick_pull=1 but thinking it could break something? Trying to understand when that whitespace is important :) |
This was a long time ago, but the comment helps me remember why, if we didn't put the whitespace in, then somehow if you have the following 2 requests:
They would be both aggregated under the same (maybe under Sorry it's probably not very clear but maybe if you remove and try to run the tests they would fail? (hoping that tests test for this) |
I've tryed https://github.com/matomo-org/matomo/compare/3.x-dev...13841_2?quick_pull=1 Datas are added to origin line (the one that exist before 3.8.0-b4). Back to origin title hash ? But second "new line" is still there. New title hash ? |
@eldk not sure what you mean by "Back to origin title hash ?" and "New title hash"? If it still appears there's a good chance you may need to invalidate some report data see https://matomo.org/faq/how-to/faq_155/ If you can access the server you can for example execute a command like |
@tsteur : thanks, it's ok (with your PR applyed and datas reprocessed). And titles with
origin title hash = title hash before 3.8.0-b4 With your PR #13895 : back to origin title hash. |
Hello,
Page "Actions_SubmenuPageTitles" begin to display two lines in report for same page.
Each line have columns "Pageviews ..." with different numbers.
"Open Transitions" and "Open Raw Evolutions" gives same datas for the two lines.
First seen on a domain with one page from which title have not been modified and no change at all on server.
Matomo version was 3.8.0-b4. I have upgraded to 3.8.0-b5 : no change : one page title gives two lines in report.
It's happened on a second domain with more pages too.
It's look like something change past some event or date as ?
Thanks,
Eric
The text was updated successfully, but these errors were encountered: