Use Request::processRequest in UserId::isUsedInSite. #13875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
the
not-in-changelog
tsteur
reviewed
Dec 18, 2018
| 'columns' => 'nb_users', | ||
| 'idSite' => $idSite, | ||
| 'period' => $period, | ||
| 'date' => $date, |
There was a problem hiding this comment.
does segment need to be set to false or this automatically happens because of $defaultRequest = []? Never really sure what happens if the system maybe picks it up somehow... Maybe doesn't hurt to mention segment => false? Eg the segment string might be read from $_SERVER['QUERY_STRING] here https://github.com/matomo-org/matomo/blob/3.8.0-b5/core/API/Request.php#L512-L518 because of https://github.com/matomo-org/matomo/blob/3.8.0-b5/core/API/Request.php#L592-L594 etc
Otherwise looks good to merge 👍
There was a problem hiding this comment.
Segments are handled very strangely in matomo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.