Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generated unique request ID used in logs as custom HTTP header. #13874

Merged
merged 2 commits into from Dec 19, 2018
Merged

Add generated unique request ID used in logs as custom HTTP header. #13874

merged 2 commits into from Dec 19, 2018

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 18, 2018
@diosmosis diosmosis added this to the 3.8.0 milestone Dec 18, 2018
@tsteur
Copy link
Member

tsteur commented Dec 18, 2018

haven't tested but looks good.

@diosmosis
Copy link
Member Author

diosmosis commented Dec 19, 2018 •
edited

@tsteur FYI, added the request ID to error reports as well (ie, via $lastError). Should show up in emails.

@diosmosis diosmosis merged commit 4af5d44 into 3.x-dev Dec 19, 2018
@diosmosis diosmosis deleted the request-id-header branch December 19, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur