Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak message when an error in session happens #13857

Merged
merged 2 commits into from Dec 13, 2018
Merged

Tweak message when an error in session happens #13857

merged 2 commits into from Dec 13, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 13, 2018

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 13, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 13, 2018
tsteur referenced this pull request Dec 13, 2018
* use db sessions by default, deprecate file session handler

* trying to fix tests
@diosmosis diosmosis merged commit 3a655d1 into 3.x-dev Dec 13, 2018
@diosmosis diosmosis deleted the 13852 branch December 13, 2018 23:42
@GreenReaper
Copy link

GreenReaper commented Dec 14, 2018

Perhaps I'm misunderstanding, but this seems to be missing the point - the issue is the block above, which recommends DB sessions if DbHelper::isInstalled(), regardless of whether it is already in use. 😅

The error reported occurred when I had dbfile enabled (by default) but the 'data?' preceding the Base64 serialized representation in the data row had been removed. The actual error message below the "try using the database session handler" block correctly identified a corrupted session in the database, and reported that it had deleted the session in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants