Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop failing when CIP tracking parameter is set but not authenticated #13854

Closed
tsteur opened this issue Dec 13, 2018 · 5 comments
Closed

Stop failing when CIP tracking parameter is set but not authenticated #13854

tsteur opened this issue Dec 13, 2018 · 5 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.8.0

Comments

@tsteur
Copy link
Member

tsteur commented Dec 13, 2018

see eg matomo-org/matomo-php-tracker#39

in #13675 we started failing the tracking request when no CIP parameter is set. However, I noticed that by default we always set the CIP parameter in the PHP tracker. So if someone now uses the php tracker without a valid token, all tracking requests will fail. Maybe we should wait for Matomo 4 for this change?

We could restore old behaviour and use the REMOTE_ADDR as a fallback instead when no token provided. @mattab ?
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 13, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 13, 2018
@mattab
Copy link
Member

mattab commented Dec 13, 2018

Sounds good @tsteur
Reckon it's important to address this as currently it must break a lot of PHP SDK usages.

@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 13, 2018
@diosmosis
Copy link
Member

@tsteur is this fixed by this revert: #13858 ?

@tsteur
Copy link
Member Author

tsteur commented Dec 16, 2018

We would only need to revert this line: https://github.com/matomo-org/matomo/pull/13858/files#diff-6700aaf1ce500fe51e284b9ec6f01b01L892

for the other ones (userCountry) it be still good to fail if they are specified.

@diosmosis
Copy link
Member

diosmosis commented Dec 16, 2018 •
edited

I'm not sure what you mean, that line was reverted in the revert PR, or am I missing something?

@tsteur
Copy link
Member Author

tsteur commented Dec 16, 2018

Getting confused now as well. Didn't see this was reverted :) Ideally, we would have only reverted the line I mentioned but kept the other ones. (hoping this clarifies it a bit more).

Cause city, country etc is not set by the PHP tracker or so. This way it's fine to fail the tracking request so users become aware there is a tracking problem.

@diosmosis diosmosis mentioned this issue Dec 16, 2018
Merged
@NicoHood NicoHood mentioned this issue Dec 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.8.0
Development

No branches or pull requests
3 participants
@diosmosis @tsteur @mattab