Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger new event when a tracker has been added #13851

Merged
merged 1 commit into from Dec 13, 2018
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 13, 2018

This is needed for some premium features where we extend the tracker. Listening to TrackerSetup event doesn't work there because once this event is triggered, the plugins will call Piwik.getAsyncTrackers() but on the TrackerSetup event the tracker has only just been created and not yet added to the list of async trackers. We therefore need to trigger an event when a new tracker is added to the list of async trackers. Those are all internal APIs so no need re developer changelog.

@tsteur tsteur added the Needs Review PRs that need a code review label Dec 13, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 13, 2018
@diosmosis diosmosis merged commit c7f8106 into 3.x-dev Dec 13, 2018
@diosmosis diosmosis deleted the trackeraddedevent branch December 13, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants