Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Themes to System Menu #13848

Closed
wants to merge 1 commit into from
Closed

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Dec 13, 2018

fixes #13211

I created a PR to get the discussion about #13211 rolling.
Personally I think most Matomo users are not aware of the fact that you can really easily change the style of Matomo just by switching out a handful of color.
My Matomo plugins that are only useful to a really small amount of people have more downloads than a theme that could be interesting to many Matomo users.

This would also allow creating more Matomo Themes as they would then be seen by more people.
(I think a high contrast accessibility and a dark/night theme would be quite useful)

Regarding the Change: Updates would still be shown in the Plugins menu, but I am not sure if showing them twice is easy to do.

@tsteur
Copy link
Member

tsteur commented Dec 13, 2018

Wouldn't users maybe discover them more through the marketplace than the themes page? I think the amount of people that would actually start developing a theme and take the time to customise the look can be likely counted on two hands or so :) And the ones that are interested in doing this, might still find it. We removed Themes from the main menu on purpose as themes are not even much used even when in main menu. Maybe instead rather add a notice in "Branding settings" that it is possible to customize themes (it would need to be possible to disable this message or it should be disabled if plugins admin is disabled)?

@Findus23
Copy link
Member Author

Wouldn't users maybe discover them more through the marketplace than the themes page?

Maybe you are right. But the marketplace page is also a bit hidden and looks broken at the moment as two of the six themes, don't have a screenshot and therefore just show src="?w=250&h=150". Maybe we could add a requirement on submitting a theme that there has to be a screenshot.
grafik

I think the amount of people that would actually start developing a theme and take the time to customise the look can be likely counted on two hands or so :)

Well in that case that would mean two times more Matomo themes 😉
We don't need as many themes as plugins, but a well maintained set of a handful different themes (especially a dark and an accessibility theme) would attract many users in my opinion.

I'm also not totally happy with this PR, but we need some other way to link to the themes page as the current link is completely invisible. Maybe someone else has an idea!

@tsteur
Copy link
Member

tsteur commented Dec 20, 2018

We don't need as many themes as plugins, but a well maintained set of a handful different themes (especially a dark and an accessibility theme) would attract many users in my opinion.

To attract more users for this we would possibly need to mention it a bit more on the website. Otherwise users would only notice it when already installed or so. We might actually mention this a bit more as part of the white label page etc.

I'll create an issue for requiring screenshots but it's a bit of work (cause we would need to change quite some logic and validate whether it has screenshots before unzipping and creating any plugin internally in the DB etc). I'll create an internal issue for this for now 👍 Maybe the developer docs could also be tweaked to highly encourage people to upload screenshots?

@Findus23
Copy link
Member Author

I'll create an issue for requiring screenshots but it's a bit of work

In that case just leave it as it is and I'll continue to contact the developers and encourage them to add screenshots (as I have done now)

@tsteur
Copy link
Member

tsteur commented Dec 20, 2018

👍 awesome

@mattab mattab added this to the 3.9.0 milestone Dec 31, 2018
@sgiehl
Copy link
Member

sgiehl commented Feb 25, 2019

@mattab code looks fine. Shall we merge this one then? Would update the tests if so...

@mattab mattab modified the milestones: 3.9.0, 3.10.0 Mar 18, 2019
@diosmosis
Copy link
Member

@mattab can you reply to this thread?

@mattab mattab closed this Apr 8, 2019
@mattab
Copy link
Member

mattab commented Apr 8, 2019

Reckon we don't need the new menu entry, but if needed we could maybe show Themes more clearly on the Plugins page itself.

@Findus23 Findus23 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 27, 2019
@tsteur tsteur deleted the add-themes-to-system-menu branch April 15, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make possibility for themes more prominent
5 participants