New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Themes to System Menu #13848
add Themes to System Menu #13848
Conversation
Wouldn't users maybe discover them more through the marketplace than the themes page? I think the amount of people that would actually start developing a theme and take the time to customise the look can be likely counted on two hands or so :) And the ones that are interested in doing this, might still find it. We removed Themes from the main menu on purpose as themes are not even much used even when in main menu. Maybe instead rather add a notice in "Branding settings" that it is possible to customize themes (it would need to be possible to disable this message or it should be disabled if plugins admin is disabled)? |
To attract more users for this we would possibly need to mention it a bit more on the website. Otherwise users would only notice it when already installed or so. We might actually mention this a bit more as part of the white label page etc. I'll create an issue for requiring screenshots but it's a bit of work (cause we would need to change quite some logic and validate whether it has screenshots before unzipping and creating any plugin internally in the DB etc). I'll create an internal issue for this for now 👍 Maybe the developer docs could also be tweaked to highly encourage people to upload screenshots? |
In that case just leave it as it is and I'll continue to contact the developers and encourage them to add screenshots (as I have done now) |
👍 awesome |
@mattab code looks fine. Shall we merge this one then? Would update the tests if so... |
@mattab can you reply to this thread? |
Reckon we don't need the new menu entry, but if needed we could maybe show Themes more clearly on the Plugins page itself. |
fixes #13211
I created a PR to get the discussion about #13211 rolling.
Personally I think most Matomo users are not aware of the fact that you can really easily change the style of Matomo just by switching out a handful of color.
My Matomo plugins that are only useful to a really small amount of people have more downloads than a theme that could be interesting to many Matomo users.
This would also allow creating more Matomo Themes as they would then be seen by more people.
(I think a high contrast accessibility and a dark/night theme would be quite useful)
Regarding the Change: Updates would still be shown in the Plugins menu, but I am not sure if showing them twice is easy to do.