Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archiving goals should not trigger segment archiving #13841

Closed
tsteur opened this issue Dec 12, 2018 · 2 comments
Closed

Archiving goals should not trigger segment archiving #13841

tsteur opened this issue Dec 12, 2018 · 2 comments
Labels
worksforme The issue cannot be reproduced and things work as intended.
Milestone
3.10.0

Comments

@tsteur
Copy link
Member

tsteur commented Dec 12, 2018

I ran this command

./console core:archive --piwik-domain=foo.bar.baz --concurrent-requests-per-website=1 -- --force-idsites=1 --force-periods=day --skip-all-segments

and noticed it was archiving segments in the mysql processlist for all kind of reports. The queries were definitely caused by a regular API.get&trigger=archivephp.

Looking at a backtrace the segments might be archived because of https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Goals/API.php#L431-L441 but would have expected it wouldn't do a full archive anymore since #13105
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 12, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 12, 2018
@diosmosis diosmosis assigned diosmosis and unassigned diosmosis Dec 22, 2018
@diosmosis diosmosis modified the milestones: 3.8.0, 3.9.0 Jan 7, 2019
@mattab mattab modified the milestones: 3.9.0, 3.10.0 Mar 18, 2019
@katebutler
Copy link

I've had a look at this (using data from the visitorgenerator) and been unable to reproduce.

@tsteur
Copy link
Member Author

tsteur commented May 5, 2019

can't reproduce it either . Tested eg this way:

image

to ensure the archiving I first tracked a pageview, drop all this year's archiving table, set time_before_today_archive_considered_outdated=1 and made sure it actually archives, made sure it goes through the code referenced above, etc. and it all worked nicely.

I then removed the two lines https://github.com/matomo-org/matomo/pull/13105/files#diff-a3e66249463ecac225632c9b3a63d198R94 that process data for that segment and would have actually expected a failure and that it actually does process segments as the segments are being launched within the same archiving request.

This is odd, I really would have expected to see some archiving running for that segment. Then noticed the archiving fails when testing it in Goals\Archiver like this:
image

so the archiver is actually already smart enough by the looks to only archive that plugin when a segment is set, and not the others. Looks all good :)

@tsteur tsteur closed this as completed May 5, 2019
@tsteur tsteur added worksforme The issue cannot be reproduced and things work as intended. and removed Bug For errors / faults / flaws / inconsistencies etc. labels May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
3.10.0
Development

No branches or pull requests
4 participants
@diosmosis @tsteur @mattab @katebutler