Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WARNING: Trying to add two strings in DataTable\Row::sumRowArray #13839

Closed
mattab opened this issue Dec 12, 2018 · 7 comments
Closed

WARNING: Trying to add two strings in DataTable\Row::sumRowArray #13839

mattab opened this issue Dec 12, 2018 · 7 comments
Assignees
@tsteur
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.9.0

Comments

@mattab
Copy link
Member

mattab commented Dec 12, 2018 •
edited

just updated demo.matomo.org to beta4 and now getting heaps of warning like: WARNING: Trying to add two strings in DataTable\Row::sumRowArray: 0 + -58.4% for row # ['nb_visits' => 84389, 'nb_actions' => 302230, 'Actions_nb_pageviews' => 132551, 'Goal_revenue' => 1462.6, 'Goal_nb_conversions' => 5628, 'Goal_0_nb_conversions' => 0, 'Goal_0_revenue' => 0, 'label' => -2, 'visits_evolution' => 0, 'actions_evolution' => 0, 'pageviews_evolution' => 0, 'revenue_evolution' => 0, 'nb_conversions_evolution' => 0, 'orders_evolution' => 0, 'ecommerce_revenue_evolution' => 0, 'nb_pageviews' => 98667, 'revenue' => 307868.6, 'nb_conversions' => 3849, 'orders' => 1557, 'ecommerce_revenue' => 305945.6] [] [idsubtable = ]<br />

can be visible at: https://demo.matomo.org/index.php?module=TagManager&action=manageContainers&idSite=62&period=day&date=yesterday

it looks like this:
screenshot from 2018-12-13 10-23-10
@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 12, 2018
@mattab mattab added this to the 3.8.0 milestone Dec 12, 2018
@tsteur tsteur self-assigned this Dec 19, 2018
@tsteur tsteur mentioned this issue Dec 19, 2018
Merged
@tsteur tsteur assigned diosmosis and unassigned tsteur Dec 19, 2018
@tsteur
Copy link
Member

tsteur commented Dec 19, 2018

@diosmosis I've debugged locally and looked into code and then temporarily disabled proxysite on demo and then the error occurred. It can be reproduced on https://demo.matomo.org/index.php?module=MultiSites&action=index&idSite=1&period=day&date=yesterday when ProxySite is enabled. I think we have fixed this issue in #13853 already? The patch is now applied on the demo instance but still seems to occur?

@tsteur tsteur removed the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 19, 2018
@diosmosis
Copy link
Member

@tsteur would need to be applied on demo-proxy and demo, since the target instance would need to generate the totals row. Then demo would see it and not calculate it again. If it's on both, then would have to look some more.

@tsteur
Copy link
Member

tsteur commented Dec 19, 2018

Just to be sure as I think you mentioned it before in chat. Should I apply the whole Reports Total calculator patch on the demo so the totals row will be returned and won't be processed again?

@tsteur tsteur closed this as completed Dec 20, 2018
@tsteur
Copy link
Member

tsteur commented Dec 20, 2018

Applied the patch and it is now fixed. Can reload https://demo.matomo.org/index.php?module=MultiSites&action=index&idSite=62&period=day&date=yesterday as often as I want but does not appear anymore.

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 20, 2018
@tsteur tsteur assigned tsteur and unassigned diosmosis Dec 20, 2018
@mattab
Copy link
Member Author

mattab commented Jan 9, 2019

I'm still seeing the warnings on the demo which is running 3.8.0-rc2:

From 2019-01-07 to 2019-01-13
WARNING: Trying to add two strings in DataTable\Row::sumRowArray: 0 + 33% for row # ['label' => -2, 'nb_visits' => 6093, 'nb_hits' => 11605, 'sum_time_spent' => 768459, 'nb_hits_following_search' => 35, 'nb_hits_with_time_generation' => 10819, 'min_time_generation' => 0.003, 'max_time_generation' => 55.676, 'entry_nb_visits' => 1874, 'entry_nb_actions' => 8126, 'entry_sum_visit_length' => 455983, 'entry_bounce_count' => 648, 'exit_nb_visits' => 2212, 'sum_daily_nb_uniq_visitors' => 5323, 'sum_daily_entry_nb_uniq_visitors' => 1748, 'sum_daily_exit_nb_uniq_visitors' => 2059, 'avg_time_on_page' => 0, 'bounce_rate' => 0, 'exit_rate' => 0, 'avg_time_generation' => 0] [] [idsubtable = ]<br />

screenshot_2019-01-09 all websites dashboard - from 2019-01-07 to 2019-01-13 - web analytics reports -

@mattab mattab reopened this Jan 9, 2019
@diosmosis diosmosis mentioned this issue Jan 9, 2019
Merged
@mattab
Copy link
Member Author

mattab commented Feb 12, 2019

Still seeing the error on demo.matomo.org today, any idea @diosmosis ?

screenshot from 2019-02-12 15-46-56

@mattab mattab reopened this Feb 12, 2019
@mattab mattab modified the milestones: 3.8.0, 3.9.0 Feb 12, 2019
@mattab mattab changed the title Warnings after beta4 upgrade WARNING: Trying to add two strings in DataTable\Row::sumRowArray Feb 12, 2019
@diosmosis
Copy link
Member

Updating demo to 3.8.1 from a rc, should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.9.0
Development

No branches or pull requests
3 participants
@diosmosis @tsteur @mattab