Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure tag manager can only be deactivated, not uninstalled #13838

Merged
merged 1 commit into from Dec 12, 2018
Merged

Make sure tag manager can only be deactivated, not uninstalled #13838

merged 1 commit into from Dec 12, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 12, 2018

fix #13835

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 12, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 12, 2018
Findus23
Findus23 approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

This solves the issue for me.

@diosmosis diosmosis merged commit 70533f5 into 3.x-dev Dec 12, 2018
@diosmosis diosmosis deleted the 13835 branch December 12, 2018 20:01
@Findus23 Findus23 restored the 13835 branch October 4, 2019 09:48
@sgiehl sgiehl deleted the 13835 branch February 10, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Findus23 Findus23 Findus23 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Matomo Tag Manager can be uninstalled
3 participants
@tsteur @Findus23 @diosmosis