Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matomo Tag Manager can be uninstalled #13835

Closed
Findus23 opened this issue Dec 12, 2018 · 0 comments · Fixed by #13838
Closed

Matomo Tag Manager can be uninstalled #13835

Findus23 opened this issue Dec 12, 2018 · 0 comments · Fixed by #13838
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.8.0

Comments

@Findus23
Copy link
Member

MTM is a core plugin and shouldn't be uninstallable (only can be disabled)

Nevertheless Matomo shows a working uninstall button
grafik
See https://forum.matomo.org/t/fehler-nach-desinstallation-von-tag-manager/30904/8 for more details.

I think this is caused by

matomo/core/Plugin/Manager.php

Lines 256 to 259 in e571b67

private function isPluginUninstallable($name)
{
return !$this->isPluginBundledWithCore($name);
}

matomo/core/Plugin/Manager.php

Lines 675 to 680 in e571b67

public function isPluginBundledWithCore($name)
{
return $this->isPluginEnabledByDefault($name)
|| in_array($name, $this->pluginList->getCorePluginsDisabledByDefault())
|| $name == self::DEFAULT_THEME;
}

But TagManager is not enabled by default, but also doesn't appear in
https://github.com/matomo-org/matomo/blob/e571b67d8f6b2764a2bdbe3d017f0f9ddf147508/core/Application/Kernel/PluginList.php#L34-#L45

So I guess it should either be added to the list (which may have side effects) or maybe a special case for TagManager should be added to isPluginBundledWithCore
@Findus23 Findus23 added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 12, 2018
@Findus23 Findus23 added this to the 3.8.0 milestone Dec 12, 2018
@tsteur tsteur self-assigned this Dec 12, 2018
tsteur added a commit that referenced this issue Dec 12, 2018
@tsteur
Make sure tag manager can only be deactivated, not uninstalled
abc8d6a 
fix #13835
@tsteur tsteur mentioned this issue Dec 12, 2018
Merged
diosmosis pushed a commit that referenced this issue Dec 12, 2018
@tsteur @diosmosis
Make sure tag manager can only be deactivated, not uninstalled (#13838)
70533f5 
fix #13835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Make sure tag manager can only be deactivated, not uninstalled matomo-org/matomo
2 participants
@tsteur @Findus23