@Findus23 opened this Issue on December 12th 2018 Member

MTM is a core plugin and shouldn't be uninstallable (only can be disabled)

Nevertheless Matomo shows a working uninstall button
grafik
See https://forum.matomo.org/t/fehler-nach-desinstallation-von-tag-manager/30904/8 for more details.

I think this is caused by
https://github.com/matomo-org/matomo/blob/e571b67d8f6b2764a2bdbe3d017f0f9ddf147508/core/Plugin/Manager.php#L256-L259

https://github.com/matomo-org/matomo/blob/e571b67d8f6b2764a2bdbe3d017f0f9ddf147508/core/Plugin/Manager.php#L675-L680

But TagManager is not enabled by default, but also doesn't appear in
https://github.com/matomo-org/matomo/blob/e571b67d8f6b2764a2bdbe3d017f0f9ddf147508/core/Application/Kernel/PluginList.php#L34-#L45

So I guess it should either be added to the list (which may have side effects) or maybe a special case for TagManager should be added to isPluginBundledWithCore

This Issue was closed on December 12th 2018
Powered by GitHub Issue Mirror