Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start delete log task hourly #13824

Merged
merged 1 commit into from Dec 11, 2018
Merged

Start delete log task hourly #13824

merged 1 commit into from Dec 11, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 11, 2018

This allows plugins to better randomise when a log deletion task should be executed by eg overwriting config ( eg setting delete_logs_schedule_lowest_interval = "7.1".

It won't execute the task any more often otherwise by changing it to hourly because the deleteLogData checks when it was last executed. It's super fast this check (reading an option entry) so there is no performance problem by that.

This allows plugins to better randomise when a log deletion task should be executed by eg overwriting config ( eg setting `delete_logs_schedule_lowest_interval = "7.1"`.

It won't execute the task any more often otherwise by changing it to hourly because the `deleteLogData` checks when it was last executed. It's super fast this check (reading an option entry) so there is no performance problem by that.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 11, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 11, 2018
@diosmosis diosmosis merged commit 8a2a51c into 3.x-dev Dec 11, 2018
@diosmosis diosmosis deleted the deletelogtaskhourly branch December 11, 2018 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants