Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance mode still accepts tracking requests #13797

Open
tsteur opened this issue Dec 4, 2018 · 2 comments
Open

Maintenance mode still accepts tracking requests #13797

tsteur opened this issue Dec 4, 2018 · 2 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
Backlog (Help wan...

Comments

@tsteur
Copy link
Member

tsteur commented Dec 4, 2018

This looks like a bug. When maintenance mode is enabled, it should also block all requests to the PHP tracker API and not process any tracking requests. This is eg useful when having a long running ALTER TABLE query running and at the same time heaps of other requests are still coming in.
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 4, 2018
@tsteur tsteur added this to the 3.8.0 milestone Dec 4, 2018
@tsteur
Copy link
Member Author

tsteur commented Dec 4, 2018

Turns out there is

[Tracker]
record_statistics=0

@tsteur tsteur closed this as completed Dec 4, 2018
@tsteur tsteur added worksforme The issue cannot be reproduced and things work as intended. and removed Bug For errors / faults / flaws / inconsistencies etc. labels Dec 4, 2018
@tsteur tsteur modified the milestones: 3.8.0, Backlog (Help wanted) Dec 4, 2018
@tsteur tsteur added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. and removed worksforme The issue cannot be reproduced and things work as intended. labels Dec 4, 2018
@tsteur tsteur reopened this Dec 4, 2018
@tsteur
Copy link
Member Author

tsteur commented Dec 4, 2018

Or ideally, when maintenance_mode=1, it would assume record_statistics=0. so maintenance mode would disable UI and tracking requests. Then we could have maybe a setting to only enable maintenance_mode_ui. Wondering also if in same process record_statistics could be eventually renamed to maintenance_mode_tracker or just have it as an additional flag besides record_statistics for usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
1 participant
@tsteur