New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QR code library adds several new files to vendor dir that is breaking build #13794
Comments
I've quickly checked in the code and it looks like this code is needed :( might be wrong though. only alternative would be to maybe use another lib. I've simply reused what @sgiehl used for Google Authenticator. |
@tsteur Is there any reason to use 1.9 instead of the latest 3.5.0? I can't find the Update: |
Version 2.0 already didn't contain those files anymore. But that requires PHP 5.6. Might be worth to check if that version works with PHP 5.5 as well. Or maybe it's an option to mark the 2FA plugin as compatible with PHP 5.6 or 7 only. So users with older PHP versions can't use it |
Marking it as PHP 5.6 plus could be an idea. Actually never tried if we can require PHP version for a core plugin. |
Just added this plugin.json
as a test and it worked. However, then this error notification constantly appears which would be a bit annoying:
Looked for couple other QR Code libraries but looks like they either support 5.6+ or have those dat files. Also looked for some JavaScript alternatives... maybe https://davidshimjs.github.io/qrcodejs/ (https://github.com/davidshimjs/qrcodejs) would be a good solution? |
tested https://github.com/davidshimjs/qrcodejs but seems to print canvas and image etc.... Might try another JS lib |
also tried https://github.com/jeromeetienne/jquery-qrcode but doesn't work well either. Example in readme has typos, and the number of open issues and PRs is big. Also hasn't had a change in years. So not quite surprised it isn't working. |
Got it to work with https://github.com/davidshimjs/qrcodejs after all |
See https://travis-ci.org/matomo-org/matomo/jobs/462646517
Many files like /vendor/endroid/qrcode/assets/data/qrv36_2.dat are added. Not sure if they are needed for qr code generation or not.
CC @mattab / @tsteur
The text was updated successfully, but these errors were encountered: