@diosmosis opened this Issue on December 3rd 2018 Member

See https://travis-ci.org/matomo-org/matomo/jobs/462646517

Many files like /vendor/endroid/qrcode/assets/data/qrv36_2.dat are added. Not sure if they are needed for qr code generation or not.

CC @mattab / @tsteur

@tsteur commented on December 4th 2018 Member

I've quickly checked in the code and it looks like this code is needed :( might be wrong though. only alternative would be to maybe use another lib. I've simply reused what @sgiehl used for Google Authenticator.

@Findus23 commented on December 4th 2018 Member

@tsteur Is there any reason to use 1.9 instead of the latest 3.5.0? I can't find the assets/data files anymore in the latest version:
https://github.com/endroid/qr-code

Update:
Okay this is a reason:
https://github.com/endroid/qr-code/blob/0095706c3bf2389f15f6c097bab4a00a48fc5ff7/composer.json#L15
so -> #13611

@sgiehl commented on December 4th 2018 Member

Version 2.0 already didn't contain those files anymore. But that requires PHP 5.6. Might be worth to check if that version works with PHP 5.5 as well. Or maybe it's an option to mark the 2FA plugin as compatible with PHP 5.6 or 7 only. So users with older PHP versions can't use it

Powered by GitHub Issue Mirror