Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header color style should not be applied to menu #13789

Merged
merged 3 commits into from Dec 3, 2018
Merged

Fix header color style should not be applied to menu #13789

merged 3 commits into from Dec 3, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 2, 2018 •
edited

Otherwise, when setting for example a white background for the header, the menu items won't be visible. refs DEV-1504

@tsteur tsteur added this to the 3.8.0 milestone Dec 2, 2018
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 2, 2018
sgiehl
sgiehl approved these changes Dec 2, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@tsteur tsteur merged commit 3c1fe50 into 3.x-dev Dec 3, 2018
@tsteur tsteur deleted the fixheaderstylemenu branch December 3, 2018 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl