Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

title-text of JavaScript Tracking option help box shows HTML #13783

Closed
Findus23 opened this issue Nov 30, 2018 · 5 comments
Closed

title-text of JavaScript Tracking option help box shows HTML #13783

Findus23 opened this issue Nov 30, 2018 · 5 comments
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@Findus23
Copy link
Member

image

This seems to be caused by

matomo/plugins/CoreAdminHome/templates/trackingCodeGenerator.twig

Line 61 in e11866e

{{ 'CoreAdminHome_JSTracking_MergeSubdomainsDesc'|translate("x.<span class='current-site-host'></span>","y.<span class='current-site-host'></span>")|raw }}

and

matomo/plugins/CoreAdminHome/angularjs/trackingcode/jstrackingcode.controller.js

Line 156 in e11866e

$('.current-site-host').text(siteHost);

which of course doesn't work.
@Findus23 Findus23 added Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Nov 30, 2018
@sgiehl
Copy link
Member

sgiehl commented Jan 3, 2019

meanwhile the ui tooltips were removed from form fields. but now the browser tooltip shows up, as there is a title attribute set...
We could use data-title instead of title attributes to circumvent the browser tooltips for all formfields maybe?

@tsteur
Copy link
Member

tsteur commented Jan 3, 2019

data-title sounds good 👍

@sgiehl sgiehl mentioned this issue Jan 4, 2019
Merged
@sgiehl sgiehl self-assigned this Jan 4, 2019
@tsteur
Copy link
Member

tsteur commented Apr 11, 2019

Than for the plugins in core, but still needs to be done for other plugins

@tsteur
Copy link
Member

tsteur commented Apr 11, 2019

I think since #13442 it may not really be needed to do any more work in the plugins actually? The regular browser title might still appear for the other plugins but it may be even somewhat helpful maybe?

@sgiehl sgiehl removed their assignment Apr 28, 2020
@Findus23
Copy link
Member Author

So this has been solved with #13931 and #13442.

@Findus23 Findus23 removed the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label May 23, 2020
@Findus23 Findus23 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsteur @sgiehl @Findus23