New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable row evolution for flattened reports #13769
Conversation
I would suggest to first test it on various production systems as well. I wouldn't be surprised if this takes ages and not even sure this should be merged but to be seen re performance. |
@sgiehl I've tried this patch on https://demo.matomo.org/index.php?module=CoreHome&action=index&idSite=62&period=day&date=yesterday#?idSite=62&period=day&date=yesterday&category=General_Actions&subcategory=General_Pages&popover= but it says
it also included the flat=1 |
hm... it worked for me locally for various reports. Seems to come from the sparklines. Need to check if I'm able to reproduce it locally somehow |
@tsteur tried to reproduce that locally until I recognized that it has nothing to do with the changes here. The row evolution doesn't even work when clicking it for an unflattened page url report for that page on demo. Is that page maybe proxied or has anything special? Don't have access to that page with my account on demo, so can't look by myself... |
Good find... works for eg idSite=1. Must be an issue with the siteproxy (fyi @diosmosis ). It takes about 8 seconds to load for a flattened URL when 24 data points are shown, took more than 3 minutes when choosing 120 data points in the selector (was expected I guess). Don't wanna know how long 500 data points take :) Maybe we should remove those options for flattened reports :) (but probably not easily doable). |
@tsteur I've disabled the higher limits for flattened reports now (and also disabled the flatten selector as it doesn't make sense to unflatten an evolution chart) |
4c8e041
to
faf8f2c
Compare
tested & worked. LGTM if tests pass 👍 |
faf8f2c
to
f246958
Compare
should be tested maybe on demo or on another instance with some more data to check if performance is fine.
Also not sure if flattened custom reports are fast enough for this. ping @tsteur
fixes #7414