@sgiehl opened this Pull Request on November 26th 2018 Member

should be tested maybe on demo or on another instance with some more data to check if performance is fine.
Also not sure if flattened custom reports are fast enough for this. ping @tsteur

fixes #7414

@tsteur commented on November 26th 2018 Member

I would suggest to first test it on various production systems as well. I wouldn't be surprised if this takes ages and not even sure this should be merged but to be seen re performance.

@tsteur commented on November 26th 2018 Member
@sgiehl commented on November 26th 2018 Member

hm... it worked for me locally for various reports. Seems to come from the sparklines. Need to check if I'm able to reproduce it locally somehow

@sgiehl commented on November 26th 2018 Member
@sgiehl commented on November 27th 2018 Member

@tsteur tried to reproduce that locally until I recognized that it has nothing to do with the changes here. The row evolution doesn't even work when clicking it for an unflattened page url report for that page on demo. Is that page maybe proxied or has anything special? Don't have access to that page with my account on demo, so can't look by myself...

@tsteur commented on November 27th 2018 Member

Good find... works for eg idSite=1. Must be an issue with the siteproxy (fyi @diosmosis ).

It takes about 8 seconds to load for a flattened URL when 24 data points are shown, took more than 3 minutes when choosing 120 data points in the selector (was expected I guess). Don't wanna know how long 500 data points take :) Maybe we should remove those options for flattened reports :) (but probably not easily doable).

@sgiehl commented on November 28th 2018 Member

@tsteur I've disabled the higher limits for flattened reports now (and also disabled the flatten selector as it doesn't make sense to unflatten an evolution chart)

@tsteur commented on November 29th 2018 Member

tested & worked. LGTM if tests pass 👍

This Pull Request was closed on December 10th 2018
Powered by GitHub Issue Mirror