Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable row evolution for flattened reports #13769

Merged
merged 3 commits into from Dec 10, 2018
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 26, 2018

should be tested maybe on demo or on another instance with some more data to check if performance is fine.
Also not sure if flattened custom reports are fast enough for this. ping @tsteur

fixes #7414

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 26, 2018
@sgiehl sgiehl added this to the 3.8.0 milestone Nov 26, 2018
@tsteur
Copy link
Member

tsteur commented Nov 26, 2018

I would suggest to first test it on various production systems as well. I wouldn't be surprised if this takes ages and not even sure this should be merged but to be seen re performance.

@sgiehl
Copy link
Member Author

sgiehl commented Nov 26, 2018

hm... it worked for me locally for various reports. Seems to come from the sparklines. Need to check if I'm able to reproduce it locally somehow

@sgiehl
Copy link
Member Author

sgiehl commented Nov 27, 2018

@tsteur tried to reproduce that locally until I recognized that it has nothing to do with the changes here. The row evolution doesn't even work when clicking it for an unflattened page url report for that page on demo. Is that page maybe proxied or has anything special? Don't have access to that page with my account on demo, so can't look by myself...

@tsteur
Copy link
Member

tsteur commented Nov 27, 2018

Good find... works for eg idSite=1. Must be an issue with the siteproxy (fyi @diosmosis ).

It takes about 8 seconds to load for a flattened URL when 24 data points are shown, took more than 3 minutes when choosing 120 data points in the selector (was expected I guess). Don't wanna know how long 500 data points take :) Maybe we should remove those options for flattened reports :) (but probably not easily doable).

@sgiehl
Copy link
Member Author

sgiehl commented Nov 28, 2018

@tsteur I've disabled the higher limits for flattened reports now (and also disabled the flatten selector as it doesn't make sense to unflatten an evolution chart)

@tsteur
Copy link
Member

tsteur commented Nov 29, 2018

tested & worked. LGTM if tests pass 👍

@diosmosis diosmosis merged commit d17db09 into 3.x-dev Dec 10, 2018
@diosmosis diosmosis deleted the 7414-flat-row-evolution branch December 10, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a report is flattened, show the Row Evolution icon
3 participants