I would suggest to first test it on various production systems as well. I wouldn't be surprised if this takes ages and not even sure this should be merged but to be seen re performance.
@sgiehl I've tried this patch on https://demo.matomo.org/index.php?module=CoreHome&action=index&idSite=62&period=day&date=yesterday#?idSite=62&period=day&date=yesterday&category=General_Actions&subcategory=General_Pages&popover= but it says
Error: Expecting only one row per DataTable
Query URL in this case was https://demo.matomo.org/index.php?date=yesterday&apiMethod=Actions.getPageUrls&label=%40%252Fcart%252F&disableLink=1&module=CoreHome&action=getRowEvolutionPopover&colors=%7B%22backgroundColor%22%3A%22%23ffffff%22%2C%22lineColor%22%3A%22%23162c4a%22%2C%22minPointColor%22%3A%22%23ff7f7f%22%2C%22maxPointColor%22%3A%22%2375bf7c%22%2C%22lastPointColor%22%3A%22%2355aaff%22%2C%22fillColor%22%3A%22%23ffffff%22%7D&flat=1&idSite=62&period=day
it also included the flat=1
hm... it worked for me locally for various reports. Seems to come from the sparklines. Need to check if I'm able to reproduce it locally somehow
It works for example for https://demo.matomo.org/index.php?module=CoreHome&action=index&idSite=3&period=day&date=yesterday&updated=1#?idSite=3&period=day&date=yesterday&category=General_Actions&subcategory=General_Pages&popover=RowAction$3ARowEvolution$3AActions.getPageUrls$3A$257B$2522flat$2522$253A$25221$2522$257D$3A$40$252Fphotos.php$252Fvirtual-drums-laval-virtual-007$252F
@tsteur tried to reproduce that locally until I recognized that it has nothing to do with the changes here. The row evolution doesn't even work when clicking it for an unflattened page url report for that page on demo. Is that page maybe proxied or has anything special? Don't have access to that page with my account on demo, so can't look by myself...
Good find... works for eg idSite=1. Must be an issue with the siteproxy (fyi @diosmosis ).
It takes about 8 seconds to load for a flattened URL when 24 data points are shown, took more than 3 minutes when choosing 120 data points in the selector (was expected I guess). Don't wanna know how long 500 data points take :) Maybe we should remove those options for flattened reports :) (but probably not easily doable).
@tsteur I've disabled the higher limits for flattened reports now (and also disabled the flatten selector as it doesn't make sense to unflatten an evolution chart)
tested & worked. LGTM if tests pass 👍