Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal error triggered under some circumstances #13752

Closed
mattab opened this issue Nov 23, 2018 · 2 comments · Fixed by #14023
Closed

fatal error triggered under some circumstances #13752

mattab opened this issue Nov 23, 2018 · 2 comments · Fixed by #14023
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Nov 23, 2018

The fatal error: Neither the property "getRows" nor one of the methods "getRows()", "getgetRows()"/"isgetRows()" or "__call()" exist and have public access in class "Piwik\DataTable\Map". in plugins/CoreVisualizations/templates/_dataTableViz_htmlTable.twig line 21

Can be reproduced at https://demo.matomo.org/index.php?forceView=1&viewDataTable=..%2fWEB-INF%2fweb.xml%3bx%3d&module=MediaAnalytics&action=get&idSite=3&period=day&date=2018-10-16,2018-11-14&showtitle=1&random=84&columns=sum_total_time_watched&colors={%22backgroundColor%22%3A%22%23ffffff%22%2C%22lineColor%22%3A%22%23162c4a%22%2C%22minPointColor%22%3A%22%23ff7f7f%22%2C%22maxPointColor%22%3A%22%2375bf7c%22%2C%22lastPointColor%22%3A%22%2355aaff%22%2C%22fillColor%22%3A%22%23ffffff%22}

It is only triggered under edge case (ie. security scanner), but will be good to fix since we get this emailed to us quite a bit.

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Nov 23, 2018
@mattab mattab added this to the 3.9.0 milestone Nov 23, 2018
@sgiehl
Copy link
Member

sgiehl commented Nov 24, 2018

The problem is, that multiple dates are requested for a table visualization. The datatable loaded from API is a Map in this case, which doesn't have a ´getRows´ method. Maybe we should throw an exception if multiple dates are requested for a visualization that can't handle it?

@tsteur
Copy link
Member

tsteur commented Nov 24, 2018

There's also a random viewDataTable used etc. I don't think it's a bug and neither anything needs to be done. It's not really important or efficient to try avoid all of these. You'd need to add this to all visualisations, etc. Feel free to do so though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants