Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't allow chrome to translate Matomo pages #13748

Merged
merged 1 commit into from Nov 26, 2018
Merged

don't allow chrome to translate Matomo pages #13748

merged 1 commit into from Nov 26, 2018

Conversation

Findus23
Copy link
Member

avoid unintentionally sending private data to foreign servers by Matomo users who have selected "always translate $language" in Chrome/Chromium

Currently this story of a webmail user who noticed that all his messages where sent to Google translate is going arround:
https://old.reddit.com/r/ProtonMail/comments/9yl94k/never_connect_to_protonmail_using_chrome/

While I don't believe that this happened without clicking on translate at least once, I think it shouldn't even be possible to accidentally send all Matomo do other servers.

Bonus fix: The safemode template was missing <meta charset="utf-8">. I am not sure if this was intentionally, but I think it is required for a proper HTML5 utf-8 page.

@Findus23
don't allow chrome to translate Matomo pages
48dbea5 
avoid unintentionally sending private data to foreign servers
@Findus23 Findus23 added c: Privacy For issues that impact or improve the privacy. Needs Review PRs that need a code review labels Nov 22, 2018
rugk
rugk approved these changes Nov 22, 2018
View reviewed changes
Copy link

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Ref threema-ch/threema-web#681

@tsteur
Copy link
Member

tsteur commented Nov 22, 2018

Should be good to merge if tests pass. What does it exactly do though? Can people still translate eg an admin page if they want to? It may be helpful for some people to translate some admin pages on occasion. Not everyone knows they can change language etc. Not a problem though if not possible anymore I suppose, just be good if it is still possible.

@Findus23
Copy link
Member Author

@tsteur
https://support.google.com/webmasters/answer/79812?hl=en says the following regarding notranslate.

When we recognize that the contents of a page are not in the language that the user is likely to want to read, we often provide a link to a translation in the search results. In general, this gives you the chance to provide your unique and compelling content to a much larger group of users. However, there may be situations where this is not desired. This meta tag tells Google that you don't want us to provide a translation for this page.

A quick test shows that I can still translate the page like before via right click, but setting Chrome to always translate German to English leaves the page alone.

@tsteur
Copy link
Member

tsteur commented Nov 22, 2018

👍

@Findus23 Findus23 added this to the 3.8.0 milestone Nov 25, 2018
@diosmosis diosmosis merged commit cb54533 into 3.x-dev Nov 26, 2018
@diosmosis diosmosis deleted the no-google-translate branch November 26, 2018 00:55
@Findus23 Findus23 restored the no-google-translate branch October 4, 2019 09:49
@sgiehl sgiehl deleted the no-google-translate branch February 10, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugk rugk rugk approved these changes

Assignees
No one assigned
Labels
c: Privacy For issues that impact or improve the privacy. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Findus23 @tsteur @rugk @diosmosis