Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CustomDimensions repo. #13745

Merged
merged 1 commit into from Nov 22, 2018
Merged

Update CustomDimensions repo. #13745

merged 1 commit into from Nov 22, 2018

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 22, 2018
@diosmosis diosmosis added this to the 3.8.0 milestone Nov 22, 2018
@diosmosis
Copy link
Member Author

UI tests are failing, but they appear to be due to the theme changes, so will merge this & fix plugin build in new PR.

@diosmosis diosmosis merged commit 1fac9a1 into 3.x-dev Nov 22, 2018
diosmosis added a commit that referenced this pull request Nov 22, 2018
@diosmosis
Revert "Update CustomDimensions repo. (#13745)"
ca1aec5 
This reverts commit 1fac9a1.
@diosmosis
Copy link
Member Author

Ugh, wrong PR

@diosmosis diosmosis deleted the update-custom-dims branch November 22, 2018 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur