Improve check for dangerous links... #13731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
c: Tests & QA
|
It might be better to run But I have to admit, the difference is very minor on my system. And the performance gain will cannibalize itself, as soon as you use more wildcards. |
tsteur
reviewed
Nov 19, 2018
| @@ -82,11 +82,11 @@ describe("TagManagerTeaser", function () { | |||
| }); | |||
|
|
|||
| it('should be possible to disable page and redirect to home', function (done) { | |||
| capturePage(done, 'admin_page_disable', function (page) { | |||
| expect.page("").contains("#dashboard", function (page) { | |||
There was a problem hiding this comment.
there is no screenshot name etc... and shouldn't it capture?
There was a problem hiding this comment.
yes. it now only checks if the loaded page has the element #dashboard. Imho there is no need to compare the actual content as a screenshot
|
closing in favor of #13741 |
sgiehl
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some other UI test related stuff