@diosmosis opened this Pull Request on November 19th 2018 Member

Changes:

  • when getting archive IDs must not ignore idarchives w/ different done flags.
    conversion rate requires number of conversions and number of visits, which will appear in two different archives, one for Goals, one for VisitsSummary. W/o grouping by name, only one was selected, the one for Goals. Which meant nb_visits was queried as 0, causing a conversion rate of 0.
  • and aggregate dependent plugins for aggregate periods too.
@diosmosis commented on November 19th 2018 Member

Some tests will need updating otherwise, ready for review.

@tsteur commented on November 22nd 2018 Member

👍 fyi some tests are now failing as I think lots of more archives are created now etc. LGTM otherwise. Be ideal if we didn't have to generate all the archives when processing the segments to speed up archiving and reduce needed storage but I'm not sure we can detect whether we are currently processing a dependent archive or not.

@diosmosis commented on November 22nd 2018 Member

I'm not sure what you mean? It should only process the Goals plugin for those dependent segments, but since it's a period, it will have to aggregate child periods. Or are the child periods being aggregated multiple times if, eg, month then year gets run (so month gets archived once, then again when year cascades)? That seems like something worth fixing.

@tsteur commented on November 22nd 2018 Member

I meant some/many of the Goal metrics/archives are maybe not needed to be archived. All good though.

This Pull Request was closed on November 24th 2018
Powered by GitHub Issue Mirror