It is not possible to record more than one conversion per second for the same visit #13727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same visit fix #9916 we randomize the first 2 numbers increasing the chances to record multiple goal conversions per second per visit.
tsteur
added
not-in-changelog
sgiehl
requested changes
Nov 25, 2018
core/Tracker/GoalManager.php
Outdated
| private function makeRandomMySqlUnsignedInt($length) | ||
| { | ||
| // mysql int unsgined max value is 4294967295 so we cannot start with a 5 or higher | ||
| return Common::getRandomString(1, '1234') . Common::getRandomString($length - 1, '0123456789'); |
There was a problem hiding this comment.
But couldn't this still create to high values between 4294967296 and 4999999999
sgiehl
reviewed
Nov 26, 2018
core/Tracker/GoalManager.php
Outdated
| } | ||
| if ($length > 2) { | ||
| $randomInt .= Common::getRandomString($length - 2, '0123456789'); | ||
| } |
There was a problem hiding this comment.
Actually even that could generate a too high number, even though the range is now much smaller between 4294967295 and 4299999999. Maybe it would be simpler to restrict the number to be between 1000000000 and 3999999999, e.g. disallow the 4 as first char?
There was a problem hiding this comment.
sure, makes totally sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9916
we randomize the first 2 numbers increasing the chances to record multiple goal conversions per second per visit.