Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lbraces in widget names before setting widget titles. #13715

Merged
merged 1 commit into from Nov 21, 2018
Merged

Fix lbraces in widget names before setting widget titles. #13715

merged 1 commit into from Nov 21, 2018

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 14, 2018
@diosmosis diosmosis added this to the 3.8.0 milestone Nov 14, 2018
sgiehl
sgiehl approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work as expected, but actually I'm not sure if that might cause any double encoding in some cases.

@diosmosis
Copy link
Member Author

Since I changed it from .text(...) to .html(escape(...)), it should be ok?

@sgiehl
Copy link
Member

sgiehl commented Nov 20, 2018

Guess should be fine

@diosmosis diosmosis merged commit 0b9d131 into 3.x-dev Nov 21, 2018
@diosmosis diosmosis deleted the widget-name-lbrace-fix branch November 21, 2018 00:08
@mattab mattab mentioned this pull request Dec 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl