Use angular to sanitize plugin description. #13714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Nov 14, 2018
| @@ -141,7 +141,7 @@ | |||
| </div> | |||
| <div class="plugin-desc-text"> | |||
|
|
|||
| {{ plugin.info.description|raw|nl2br }} | |||
| <div ng-bind-html="{{ plugin.info.description|raw|nl2br|json_encode|e('html_attr') }}"></div> | |||
There was a problem hiding this comment.
It seems the only plugin that uses html is custom variables? I'd be tempted to simply not allow HTML in the plugin description.
There was a problem hiding this comment.
Don't have an opinion personally.
There was a problem hiding this comment.
I'll remove the HTML from custom variables and no longer allow HTML there.
tsteur
reviewed
Dec 6, 2018
| @@ -150,7 +150,7 @@ | |||
| 'https://matomo.org', 'https://www.matomo.org', 'https://matomo.org/', 'https://www.matomo.org/' | |||
| ] %} | |||
| <span class="plugin-homepage"> | |||
| <a target="_blank" rel="noreferrer noopener" href="{{ plugin.info.homepage }}">({{ 'CorePluginsAdmin_PluginHomepage'|translate|replace({' ': ' '})|raw }})</a> | |||
| <a target="_blank" rel="noreferrer noopener" href="{{ plugin.info.homepage|e('url') }}">({{ 'CorePluginsAdmin_PluginHomepage'|translate|replace({' ': ' '})|raw }})</a> | |||
There was a problem hiding this comment.
e('url') cannot be used on a full link, but only on a component. It breaks the URL...
I'll replace it with html_attr
|
@diosmosis see last commit, I fixed the homepage URL link and no longer allow HTML in the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.