@mattwwarren opened this Pull Request on October 29th 2013

As mentioned in http://dev.piwik.org/trac/ticket/4230#comment:3, an optional match was added to the log detection regex

@diosmosis commented on November 13th 2013 Member

The regex changes are incorrect. The changes will match "1.2.3.4, 3.4.5.6" as one group. The desired behavior is "1.2.3.4" to be matched and the rest ignored. Note: the brackets you used ('[ ... ]') will create a character class and because you place a space plus \S (represents any non-space character) within it, the change will match any character.

This Pull Request was closed on December 8th 2013
Powered by GitHub Issue Mirror