Update date in page title correctly #13697
Conversation
sgiehl
added
the
not-in-changelog
| if (0 === originalTitle.indexOf(piwik.siteName)) { | ||
| var dateString = ' - ' + piwikPeriods.parse(period, date).getPrettyString() + ' '; | ||
| document.title = piwik.siteName + dateString + originalTitle.substr(piwik.siteName.length); | ||
| } |
There was a problem hiding this comment.
Are there any cases where the date should be added and the document title does not include the site name? If there are, then this won't add the dates to those titles.
There was a problem hiding this comment.
Wasn't 100% sure if that might be the case somewhere. That's the reason for the if.
But the target was to put the date after the website name again. See https://github.com/matomo-org/matomo/pull/12222/files#diff-1eb3ce37602c6f5a47792ccdf0bce2ff
There was a problem hiding this comment.
I see... actually since the site/period is used to query report data, I don't think it would make sense for this case to occur. The period should only be there if the site is there... Actually nevermind, it might affect the all websites dashboard? I'll test locally today sometime.
There was a problem hiding this comment.
your solution solves my problem, thank you. see #13696
replaces #13696
fixed #13649