@tsteur opened this Pull Request on November 8th 2018 Member

Doesn't require a note in the developer changelog but we should ideally mention this in the changelog as it is changing the behaviour for people that actually want to use it.

Tested it locally and worked.

fix #2956

@sgiehl commented on November 11th 2018 Member

Guess it makes sense to set it empty by default. Regarding mentioning it in a changelog: Might it make sense to trigger a notification within Matomo after updating to explain the possible change to the super user once?

@tsteur commented on November 11th 2018 Member

I reckon it's not needed as long as it is mentioned clearly in the regular changelog. I suppose not too many people are too keen on how this feature worked previously and might maybe rather confuse people?

@sgiehl commented on November 11th 2018 Member

Guess you're right. The page title report might not be one of the frequently used reports at all

@diosmosis commented on November 26th 2018 Member

Looks like this change causes issues in displaying the "Page Name not defined" text, not sure why on first glance.

@tsteur commented on November 26th 2018 Member

pushed a fix that hopefully resolves the issue. I'll have a look at the failing tests and update them later.

@tsteur commented on November 26th 2018 Member

Things should work now. There were various bugs around the delimiter in the code and the code is quite hard to understand / messy. Also added to some tests the delimiter with / to make sure this doesn't regress.

This Pull Request was closed on November 29th 2018
Powered by GitHub Issue Mirror