Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto zoom real time and visitor map #13687

Merged
merged 2 commits into from Nov 26, 2018
Merged

Auto zoom real time and visitor map #13687

merged 2 commits into from Nov 26, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 8, 2018

Tested it locally and worked.

Real-time map: Zooming into a country when all visits come from same country. Zooming into a continent when all visits come from same continent.

Visitor map: Zooming into a country when all visits come from same iso code...

Not sure actually how often this happens in real life.

fix #4301

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 8, 2018
@tsteur tsteur added this to the 3.8.0 milestone Nov 8, 2018
@fdellwing
Copy link
Contributor

fdellwing commented Nov 9, 2018

Not sure actually how often this happens in real life.

We provide industry software, it happens every day for us ;)

Also: I applied the patch and it does not seem to work? Might have been a cache problem, it works.

@diosmosis
Copy link
Member

tested locally, works well

@diosmosis diosmosis merged commit a7e06ca into 3.x-dev Nov 26, 2018
@diosmosis diosmosis deleted the 4301 branch November 26, 2018 04:02
@fdellwing
Copy link
Contributor

Well I would have not merged it until #13691 is resolved, but ok. I guess there will be only a few questions why people are seeing an empty map.

@tsteur
Copy link
Member Author

tsteur commented Nov 26, 2018

We could otherwise disable temporarily the zoom into country and only zoom into continent if that helps until the other issue is fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visitor Profile - Zoom map as near as possible
3 participants