@tsteur opened this Pull Request on November 8th 2018 Member

When changing email or password, the password will be required for the current user.

refs https://github.com/matomo-org/plugin-LoginLdap/pull/174
fix https://github.com/matomo-org/matomo/issues/2932

Todo: We need to update either this PR or #13472 depending on which one gets merged first to apply brute force / lock down changes

@diosmosis commented on November 27th 2018 Member

Noticed one thing while testing locally: whenever the password confirm comes up, I would immediately enter my password (which would work since it is focused), then press enter. But that doesn't submit the modal, so I'd have to click Yes explicitly. Might be good to add this behavior, was annoying to me at least.

@tsteur commented on November 29th 2018 Member

@diosmosis I'm resolving merge conflicts and fixing tests... is this otherwise good to merge?

@tsteur commented on November 29th 2018 Member

Noticed one thing while testing locally: whenever the password confirm comes up, I would immediately enter my password (which would work since it is focused), then press enter. But that doesn't submit the modal, so I'd have to click Yes explicitly. Might be good to add this behavior, was annoying to me at least.

I'll quickly look into it but have a feeling it might not be so easy

@tsteur commented on November 29th 2018 Member

added the "enter" functionality @diosmosis

@diosmosis commented on November 29th 2018 Member

@tsteur 👍 looks good

This Pull Request was closed on November 29th 2018
Powered by GitHub Issue Mirror