@mattab opened this Issue on November 7th 2018 Member

assuming that the trial went well, then in Matomo 4.0.0 we would like to enable the feature alwaysUseSendBeacon by default.

see https://github.com/matomo-org/matomo/pull/13451 https://github.com/matomo-org/matomo/issues/6641

@Findus23 commented on November 8th 2018 Member

Keep in mind that a large portion of users have sendbeacon disabled for privacy reasons. Disabling in Firefox via the about:config key beacon.enabled removes navigator.sendBeacon so the fallback should work.
The popular open source adblocker uBlock origin also has a (enabled by default) setting to remove sendbeacon and <a ping>, but in my test the request still worked.

So we should do a lot of testing to avoid the fallback not working (e.g. if navigator.sendBeacon still exists, but is blocked).

@tsteur commented on November 8th 2018 Member

One thing to keep in mind is that the callback parameter won't work anymore (because there is no event or what so ever when the request is finished). Some users rely on this see eg https://github.com/matomo-org/matomo/issues/13679#issuecomment-436748761

@tsteur commented on November 8th 2018 Member

Actually, callbacks won't be a problem cause we call the callback if the browser confirms it sent the request.

Powered by GitHub Issue Mirror