@tsteur opened this Pull Request on November 7th 2018 Member

refs https://github.com/matomo-org/matomo/issues/10914

@mattab as discussed pre-filling DB values from environment optionally. Supported are:

  • MATOMO_DATABASE_HOST
  • MATOMO_DATABASE_ADAPTER
  • MATOMO_DATABASE_TABLES_PREFIX
  • MATOMO_DATABASE_USERNAME
  • MATOMO_DATABASE_PASSWORD
  • MATOMO_DATABASE_DBNAME

and as fallback if that is not defined (we could also remove that fallback)

  • DATABASE_HOST
  • DATABASE_ADAPTER
  • DATABASE_TABLES_PREFIX
  • DATABASE_USERNAME
  • DATABASE_PASSWORD
  • DATABASE_DBNAME

The structure being taken from the global ini as in MATOMO_$CATEGORY_$SETTINGNAME.

I'm not going to implement that it overrides the config and that Matomo could be basically even used without config etc. Some settings will need to be writable I suppose and won't be possible to be set through environment variables. I wouldn't want it in core actually, and to overwrite / configure any environment setting I suggest this will be implemented in a separate plugin which can be put on the marketplace. For performance etc I wouldn't want to check environment variables for heaps of settings etc.

@tsteur commented on November 7th 2018 Member

As mentioned in the issue developed https://github.com/matomo-org/plugin-EnvironmentVariables but haven't tested it. If someone can confirm this works, we can publish it on the marketplace.

@baywet commented on November 14th 2018

I can test it, but not immediately, what do I need to do to test it? install matomo from this specific branch? Could you provide me a documentation on how to get the equivalent of the matomo.zip (release) from this branch please?

@tsteur commented on November 14th 2018 Member

Easiest be to download the regular matomo.zip, install, and then replace the content of the file plugins/Installation/FormDatabaseSetup.php with this content: https://raw.githubusercontent.com/matomo-org/matomo/04381b4bec7a9afa7f923bd3dc1769e4e4768aa0/plugins/Installation/FormDatabaseSetup.php

@baywet commented on November 14th 2018

thanks! I'll try that as soon as I have a minute and let you know how it works

Powered by GitHub Issue Mirror